Conversation
From he looks of it, just changing the library to the better djitellopy library, the simulator still works perfectly. Please let me know if it does not work.
azbones
left a comment
azbones
left a comment
There was a problem hiding this comment.
Yes, I just tested your branch with my drone and everything seemed to work fine. Can you also please update the setup.py settings so that the install now includes the new library? You can update the version in that file from 0.0.1 to 0.0.2. After we merge your contributions, I can update the README to reflect the change in the library and also thank you for bringing it up and making a contribution. @sean-schaefer I looked through the new lib and didn't see anything that looked like it wouldn't work with our existing command sets, but you might double check.
Thanks for taking the initiative and making a contribution!!!!
|
Hey @dullahgtt, thanks for your effort here. I went through some testing with my drone and I think we'll need to make a few more changes as the API for djitellopy is a little bit different. Currently when we deploy the drone, we call the send_command function from easy tello, which waits for a response from the drone. That function doesn't exist in djitellopy, but they do have two similar functions: send_command_with_return and send_command_without_return. I haven't dug too deep yet but it's possible we could drop-in replace with the "with return" function, though I would probably want to review the whole API and confirm if there's not any better integration points. If you have the bandwidth to look into those additional changes, that would be much appreciated, but I can also investigate further when I get some more free time, probably in a week or so. Thanks again! |
3 participants
From he looks of it, just changing the library to the better djitellopy library, the simulator still works perfectly. Please let me know if it does not work.